fix: prevent start/stop of the service during update #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we stop the service during the installation, we could interrupt any ongoing activity. We should instead rely in apt and needrestart to restart the service if needed.
Also be aware that stopping
arduino-routerwill stop all its dependencies includingarduino-app-cliwhich could interrupt any ongoing activity, including an update.Change description
Revert deb script to previous change https://github.com/arduino/arduino-router/blob/a43957bef7f323a2ec4c19ff5bd5e508d96069bd/debian/arduino-router/DEBIAN/postinst
Additional Notes
Reviewer checklist
main.